Fix file name information for .included code.#161
Open
athas wants to merge 1 commit intoTheThirdOne:masterfrom
Open
Fix file name information for .included code.#161athas wants to merge 1 commit intoTheThirdOne:masterfrom
athas wants to merge 1 commit intoTheThirdOne:masterfrom
Conversation
Author
|
Hm, this seems to break the assembler for some other programs somehow. |
The sourceProgram is not correct for statements that come from an .include, and the assembler depends on the sourceProgram actually being the "top-level" program, not the actual file. Fixes TheThirdOne#160.
Author
|
Man is the assembler logic tangled. I made it work by having a specific field (only used for diagnostics) that contains the file name of the statement. |
athas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that ProgramStatements now refer to the file they actually occur in, like is the case for the original SourceLine. This is used for various diagnostics messages.
Fixes #160.